Improve coverage #4228
Merged
Improve coverage #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
approved these changes
Sep 11, 2024
spec/system/sign_in_spec.rb
Outdated
| context "rendering the sign-in help page" do | ||
| before do | ||
| payload = { | ||
| base_path: "/help/sign-in", |
There was a problem hiding this comment.
Non-blocking nitpick. This should be /sign-in to match the base_path used in the rest of these tests.
There was a problem hiding this comment.
Oh yeah, d'oh. Thanks!
KludgeKML
force-pushed
the
improve-coverage
branch
from
e3b2d84
to
13fd4e1
Compare
- the links in the travel advice index are all countries, and countries have to have a name (it's required in the schema), so no need to test here.
- this method is never called.
- Add tests to complete coverage
- Fix this bug, and update the tests that were all passing only because this bug existed. - Remove the dev-mode only passthrough, as its not clear it's needed (probably only useful for local testing of email-alert-frontend, and even then its probably better to test end-to-end in integration).
- details is required in the schema, so remove test for it in the delegation block - places must not be nil, so remove safe navigation marker in preposition - Update tests to test #preposition.
KludgeKML
force-pushed
the
improve-coverage
branch
from
d14ff94
to
552a956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Various updates to improve coverage, plus bug fixes discovered while improving coverage:
Current improvement in line coverage: 97.99% -> 98.47%
Current improvement in branch coverage: 86.36% -> 89.39%
Why
As we move the routes from government-frontend over, the better our existing coverage the easier it will be to spot coverage problems in the new code. Ideally if we have 100% line coverage, any lack of coverage in the new code will stick out like a sore thumb. We should also strive for 100% branch coverage as a secondary goal.
https://trello.com/c/cCAkk9wZ/300-consolidate-4-frontend-apps
How
Screenshots?