Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable corrections for homepage search field #4181

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Disable corrections for homepage search field #4181

merged 1 commit into from
Jul 30, 2024

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Jul 30, 2024

What

Disable corrections for homepage search field

Why

As part of our work on site search, we've discovered a pain point where mobile browsers' autocorrection features mess up user queries, especially when it comes to domain specific terminology. For example, searches for "HMRC" are frequently autocorrected to "Hercules", or searches for "SORN" to "sworn".

See: alphagov/govuk_publishing_components#4112

How

  • Bump govuk_publishing_components to 40.1.0
  • Set disable_corrections parameter for search component in homepage header

As part of our work on site search, we've discovered a pain point where
mobile browsers' autocorrection features mess up user queries,
especially when it comes to domain specific terminology. For example,
searches for "HMRC" are frequently autocorrected to "Hercules", or
searches for "SORN" to "sworn".

- Bump `govuk_publishing_components` to 40.1.0
- Set `disable_corrections` parameter to `search` component in homepage
  header
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4181 July 30, 2024 11:47 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Apologies if I'm jumping in with a review here, I'm trying to get all our apps updated to the latest components gem ahead of a new breaking release that I'm about to do.

Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@csutter csutter merged commit f05d80a into main Jul 30, 2024
13 checks passed
@csutter csutter deleted the search-box branch July 30, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants