Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Frontend Test Runner from Minitest to RSpec #4090
Convert Frontend Test Runner from Minitest to RSpec #4090
Changes from all commits
e9e7b58
6592e7b
1544ede
9b50e9f
0a3c4ab
a0f14fd
dc1b989
876deaa
f155708
aa1e4e2
1083a0f
0d1a90c
990a9b3
1b7492f
e46460f
694f267
257225e
589a51d
546a0ca
5991dae
199cfc7
a6781a1
b3378ac
0a36584
026da54
f1aa5a3
e536150
6b7f6b0
32c1ea0
d69a474
4d9f00a
f21e641
8b9aba1
b3d5438
21ef040
e1bf6d0
7502b3b
99e56e2
69309c9
edafffe
e67028d
0ec12fe
357d856
5d0da1f
7f239ea
ec0d357
380fe7c
8b1c743
3fc99d6
f5995a3
90e398d
71fe74a
8c92fda
8bad6b6
9f9b20a
d4c857d
ed3466a
4e33d4b
63b3307
19f124e
eb26771
e43a10f
2d1b947
97ad358
306355b
c2c8645
5b07f63
944100f
530d057
de8608b
11664be
cd6f400
9a7a586
f050d28
aaef2fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, though I had to look up the difference between
sub
andgsub
😅.I understand that these tests are copied almost verbatim from the old minitest tests, but something to consider is whether the last clause (the
gsub
) needed? I'd expect that we'd want all of the component names to only contain_
not-
?The component name is already being dasherised in tests further down this file, which is what the
gsub
here is doing.It's also having to be undone in
it "has a correctly named spec file" do
so that the file name can be checked.I think the tests would be easier to maintain if only the tests that need the component name dasherised do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because the component names are loaded from their partials, so the sub removes the first _, then the gsub at the end converts the rest of the name from kebab case to snake case. I think for the moment we should keep this (because it matches the corresponding code in govuk_publishing_components), but we should look later at making all of these shared examples that are loaded directly from the components gem.