Merge pull request #4199 from alphagov/dependabot/bundler/govuk_ab_te…

…sting-3.0.0 Bump govuk_ab_testing from 2.4.3 to 3.0.0
alphagov · Aug 13, 2024 · e77b0dc · e77b0dc
2 parents 9010c14 + 09887c3
commit e77b0dc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -148,7 +148,7 @@ GEM
       rake (>= 13)
     googleapis-common-protos-types (1.15.0)
       google-protobuf (>= 3.18, < 5.a)
-    govuk_ab_testing (2.4.3)
+    govuk_ab_testing (3.0.0)
     govuk_app_config (9.14.0)
       logstasher (~> 2.1)
       opentelemetry-exporter-otlp (>= 0.25, < 0.29)

diff --git a/app/controllers/concerns/bank_hol_ab_testable.rb b/app/controllers/concerns/bank_hol_ab_testable.rb
@@ -1,6 +1,4 @@
 module BankHolAbTestable
-  CUSTOM_DIMENSION = 46
-
   ALLOWED_VARIANTS = %w[A B].freeze
 
   def self.included(base)
@@ -15,7 +13,6 @@ def self.included(base)
   def bank_hol_ab_test
     @bank_hol_ab_test ||= GovukAbTesting::AbTest.new(
       "BankHolidaysTest",
-      dimension: CUSTOM_DIMENSION,
       allowed_variants: ALLOWED_VARIANTS,
     )
   end

diff --git a/app/controllers/help_controller.rb b/app/controllers/help_controller.rb
@@ -9,7 +9,7 @@ def index; end
   def cookie_settings; end
 
   def ab_testing
-    ab_test = GovukAbTesting::AbTest.new("Example", dimension: 40)
+    ab_test = GovukAbTesting::AbTest.new("Example")
     @requested_variant = ab_test.requested_variant(request.headers)
     @requested_variant.configure_response(response)
   end