Skip to content

Commit

Permalink
Merge pull request #4164 from alphagov/2664-investigate-adding-javasc…
Browse files Browse the repository at this point in the history
…ript-test-coverage-and-implement-it-if-possible-l-2

Separate JavaScript files which should undergo test coverage checking from other files
  • Loading branch information
unoduetre authored Jul 19, 2024
2 parents de6662d + 81157d5 commit d5d29df
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 21 deletions.
4 changes: 3 additions & 1 deletion app/assets/config/manifest.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
//= link_tree ../images
//= link all.js
//= link es6-components.js
//= link application.js
//= link main.js
//= link dependencies.js
//= link test-dependencies.js
//= link views/travel-advice.js

//= link_tree ../builds
5 changes: 0 additions & 5 deletions app/assets/javascripts/all.js

This file was deleted.

12 changes: 3 additions & 9 deletions app/assets/javascripts/application.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
//= require govuk_publishing_components/lib
//= require govuk_publishing_components/components/govspeak
//= require govuk_publishing_components/components/image-card
//= require govuk_publishing_components/components/intervention
//= require govuk_publishing_components/components/step-by-step-nav
//= require govuk_publishing_components/components/table

//= require support
//= require_tree ./modules
// This file is linked to in the application.
//= require dependencies
//= require main
7 changes: 7 additions & 0 deletions app/assets/javascripts/dependencies.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// This file contains the dependencies required by the application.
//= require govuk_publishing_components/lib
//= require govuk_publishing_components/components/govspeak
//= require govuk_publishing_components/components/image-card
//= require govuk_publishing_components/components/intervention
//= require govuk_publishing_components/components/step-by-step-nav
//= require govuk_publishing_components/components/table
5 changes: 5 additions & 0 deletions app/assets/javascripts/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// This file should only contain the code being a part
// of this application, not its dependencies.
// It will be checked with respect to test coverage.
//= require support
//= require_tree ./modules
6 changes: 0 additions & 6 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@ class Application < Rails::Application
# Enable the asset pipeline
config.assets.enabled = true

config.assets.precompile += %w[
views/travel-advice.js
frontend.js
application.css
]

# Path within public/ where assets are compiled to
config.assets.prefix = "/assets/frontend"

Expand Down

0 comments on commit d5d29df

Please sign in to comment.