Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] eth_simulateV1 Request / Response types #901

Closed
Rjected opened this issue Jun 14, 2024 · 4 comments
Closed

[Feature] eth_simulateV1 Request / Response types #901

Rjected opened this issue Jun 14, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Rjected
Copy link
Contributor

Rjected commented Jun 14, 2024

Component

rpc

Describe the feature you would like

eth_simulateV1 (formerly eth_multicallV1) is an in-progress RPC endpoint that seems worth supporting in reth and alloy:
ethereum/execution-apis#484

We first need some basic types to for serialization / deserialization. It looks like we will want some structures analogous to these geth structs:
https://github.com/s1na/go-ethereum/blob/4c325ba5b365e44f1c33cfe7b3236bcb685ec2de/internal/ethapi/simulate.go#L46-L59
https://github.com/s1na/go-ethereum/blob/4c325ba5b365e44f1c33cfe7b3236bcb685ec2de/internal/ethapi/simulate.go#L70-L75

for the simulate interface:
https://github.com/s1na/go-ethereum/blob/4c325ba5b365e44f1c33cfe7b3236bcb685ec2de/internal/ethapi/api.go#L1255

There seem to be many test vectors in the execution-apis PR, which should be useful

Additional context

No response

@Rjected Rjected added the enhancement New feature or request label Jun 14, 2024
@JackG-eth
Copy link
Contributor

Will take this

@DoTheBestToGetTheBest
Copy link
Contributor

hey @JackG-eth are you always working on this ?

@JackG-eth
Copy link
Contributor

hey @JackG-eth are you always working on this ?

Hey feel free to, having to feel with few life issues right now and haven't got time

@DoTheBestToGetTheBest
Copy link
Contributor

hey @JackG-eth are you always working on this ?

Hey feel free to, having to feel with few life issues right now and haven't got time

no problem if you plan to work on it then i can take something else, GL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants