Add support for 'pytest' #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "test/{build => buildd}" (pytest ignores 'build' by default)
Copy 'example_project' to temp dir before each test
Minor refactoring
beczkowb
approved these changes
Apr 21, 2021
iwko
reviewed
Apr 21, 2021
| mkdir(test_project_dir_path / '.dags') | ||
| (test_project_dir_path / '.dags' / 'leftover').touch() | ||
|
|
||
|
|
||
| def dags_leftovers_exist(test_project_dir_path: Path = TEST_PROJECT_PATH): | ||
| def dags_leftovers_exist(test_project_dir_path=None): |
There was a problem hiding this comment.
Now 'TEST_PROJECT_PATH' is different for each test (tmp directory) and redefined in TestCase.setUp
iwko
reviewed
Apr 21, 2021
| @@ -31,7 +31,7 @@ class _BaseBuildReflectTest( | |||
| mixins.PrototypedDirMixin, | |||
| unittest.TestCase, | |||
| ): | |||
| proto_dir = "build/bf-projects/bf_selfbuild_project" | |||
| proto_dir = "buildd/bf-projects/bf_selfbuild_project" | |||
There was a problem hiding this comment.
'pytest' ignores 'build' and 'dist' directories by default. pytest-dev/pytest#1544
It might be "fixed" by redefining configuration for pytest in pyproject.toml OR by renaming directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor test refactoring, fix some tests:
python -m unitteststill works.To run pytest:
Test runner supports many nice features: printing logs
--log-cli-level=DEBUG, printing local variables--showlocals, auto pdb--pdbetc. More details here: https://docs.pytest.org/en/stable/usage.html