-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default MFA device selection for OneLogin #367
base: master
Are you sure you want to change the base?
Add default MFA device selection for OneLogin #367
Conversation
|
Pull Request Test Coverage Report for Build 9172670778Details
💛 - Coveralls |
Hey @brandonstrohmeyer, thank you for this PR! Please don't forget to accept the Contributer License Agreement. Goreleaser is a little tricky when it comes to CGO. Bytebase did a pretty awesome walk through. I fear we have to go a similar approach. Unfortunately, that also means I have to move the MacOS notarization to Github actions. That's going to be a little bigger pain. If you would be so kind to follow the bytebase write-up, then I can take care of the notarization later. Thanks |
@brandonstrohmeyer For the time being, may I suggest to split the two (Yubikey detection, flag for default MFA)? |
b9fa7b2
to
3ee6f2f
Compare
@brandonstrohmeyer I've reworked the build system. Can you test that I didn't mess up while merging the changes from the master branch? I don't own a Yubikey to test. Please also sign the Contributor Agreement. |
for yubikey support we require CGO support. CGO on crosscompile is hard, to avoid we build natively where suppported and disabled where not since goreleaser does only support prebuilt archives in the pro version, the brew publishing step had to be moved to a different github action
3ee6f2f
to
dc8bd3b
Compare
This PR adds support for a default MFA device with OneLogin, saving the user the trouble of the single keystroke to select their MFA device from a list.
There are two primary features:
--mfa-device
flag and global option. This flag matches the device name returned from OneLogin.The YubiKey autodetection relies on the karalabe/hid package which needs CGO enabled and appropriate C toolchain installed in order to cross compile. I did not make these changes to .goreleaser as I'm not sure exactly how the build machine is setup and what toolchains are available to use. I'm happy to make any requested changes, but am asking for a little guidance here. Opening as a Draft until the .goreleaser issue is resolved.