Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fixed bug that wasted disk space #3924

Closed
wants to merge 2 commits into from

Conversation

yqylh
Copy link
Contributor

@yqylh yqylh commented Jun 14, 2024

What do these changes do?

The interactive service generates n cache files named neo4j-xxx in the /tmp/ directory during execution, each with a size of at least 0.5GB. These files do not get deleted when the process ends. Here, n represents the number of times the interactive server has been started or restarted.

This issue was due to the previously used termination method for the compiler process, which utilized the terminate() function. Since terminate() does not facilitate a normal exit, it led to the compiler's inability to clean up the cache files it created.

Transitioning to sending the SIGINT signal ensures that the compiler exits gracefully and performs the necessary cache cleanup.

Copy link

welcome bot commented Jun 14, 2024

Thanks for submitting your first pull request! You are awesome! 🤗
Please make sure you have signed the CLA, as this is a mandatory check before a PR being merged.
Welcome to the GraphScope community! 🎉 You can meet the community on DingTalk or Slack.

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024

CLA assistant check
All committers have signed the CLA.

The interactive service generates n cache files named neo4j-xxx in the /tmp/ directory during execution, each with a size of at least 0.5GB. These files do not get deleted when the process ends. Here, n represents the number of times the interactive server has been started or restarted.

This issue was due to the previously used termination method for the compiler process, which utilized the terminate() function. Since terminate() does not facilitate a normal exit, it led to the compiler's inability to clean up the cache files it created. Transitioning to sending the SIGINT signal ensures that the compiler exits gracefully and performs the necessary cache cleanup.
Sleep for up to 10 seconds to wait for the compiler process to stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants