Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): consider path direction in path concat #3920

Merged
merged 11 commits into from
Jun 14, 2024

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Jun 14, 2024

What do these changes do?

As titled.
Now we specify the concat position in PathConcat. e.g., Assuming we want to concat left path L with right path R, then we would specify the concat position as follows:

  1. concat L=[1,2,3] and R=[3,4,5] with L.end and R.start,
  2. concat L=[1,2,3] and R=[5,4,3] with L.end and R.end,
  3. concat L=[3,2,1] and R=[3,4,5] with L.start and R.start,
  4. concat L=[3,2,1] and R=[5,4,3] with L.start and R.end.

The concatenated result, actually, can be either [1,2,3,4,5] or [5,4,3,2,1]. We choose to keep the left path in the left part in the result, i.e., the output concatenated path would be in order of [1,2,3,4,5].

Related issue number

Fixes #3765

@shirly121 shirly121 merged commit a552ba9 into alibaba:main Jun 14, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider PathExpand direction in PathJoin
3 participants