-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(coordinator): and gsctl to support FLEX interactive #3297
Conversation
8c49574
to
4a5356c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
- Coverage 42.06% 41.39% -0.68%
==========================================
Files 101 107 +6
Lines 11021 11203 +182
==========================================
+ Hits 4636 4637 +1
- Misses 6385 6566 +181
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -325,9 +322,17 @@ class SessionConfig: | |||
|
|||
@dataclass | |||
class Config(Serializable): | |||
# Solution under the FLEX architecture, choose from 'GraphScope One', 'Interactive' or 'GraphScope Insight' | |||
solution: str = "GraphScope One" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using an enum would better, like
from enum import Flag, STRICT, auto
class StrictFlag(Flag, boundary=STRICT):
RED = auto()
GREEN = auto()
BLUE = auto()
a3ee60b
to
a9ffbc9
Compare
a9ffbc9
to
9131d6f
Compare
What do these changes do?
🤖 Generated by Copilot at a3ee60b
show_log
andlog_level
attributes from theSessionConfig
class, and add them to the globalConfig
class along with a newsolution
attribute, which indicates the solution type under the FLEX architecture (link, link)./python/graphscope/gsctl/commands/common_command.py
, which defines a group of commands that are common to all solutions under the FLEX architecture, such asconnect
andclose
(link)./python/graphscope/gsctl/commands/dev_command.py
, which defines a group of commands for GraphScope development, such asinstall-deps
,make
,make-image
, andtest
(link)./python/graphscope/gsctl/gsctl.py
file, which is the main script of thegsctl
utility, to use theget_command_collection
andget_current_context
functions(link)gsctl
command-line utility in the./docs/utilities/gs.md
file, to reflect the new features and modes of operation under the FLEX architecture (link)