refactor: Upgrade the build phase of image in CI with gsctl #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
===========================================
+ Coverage 42.64% 66.81% +24.17%
===========================================
Files 100 102 +2
Lines 10817 10979 +162
===========================================
+ Hits 4613 7336 +2723
+ Misses 6204 3643 -2561
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lidongze0629
force-pushed
the
3074-refactor-gsctl
branch
from
cfa4705
to
298b6be
Compare
FLYLX
force-pushed
the
3074-refactor-gsctl
branch
3 times, most recently
from
b6b9040
to
b149a91
Compare
FLYLX
force-pushed
the
3074-refactor-gsctl
branch
from
b149a91
to
3dd6de7
Compare
Added gsctl support. Added gsctl support. add . . new test fix
FLYLX
force-pushed
the
3074-refactor-gsctl
branch
5 times, most recently
from
bc4e187
to
28a549a
Compare
FLYLX
changed the title
FLYLX
force-pushed
the
3074-refactor-gsctl
branch
from
28a549a
to
0c8eb9a
Compare
FLYLX
changed the title
lidongze0629
changed the title
lidongze0629
changed the title
add tempfile in gsctl fix gsctl.py format fix gsctl.py format
FLYLX
force-pushed
the
3074-refactor-gsctl
branch
from
0c8eb9a
to
4db854a
Compare
lidongze0629
changed the title
lidongze0629
changed the title
lidongze0629
changed the title
lidongze0629
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make bash scripts not dependent on bashly and refactor gsctl.
Related issue number
To resolve issue #3074 .
The previous pr #3101 was too messy, so I opened a new pr to submit an issue #3074 .