-
Notifications
You must be signed in to change notification settings - Fork 442
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(interactive): Introduce
call_proc
as a new physical operat…
…or and implement it (#4288) Currently have too kinds graph queries. One is adhoc query, the other is `call_proc` query. We provide two different route and APIs for these two kind of queries, but it is possible to merge `call_proc` query into adhoc query, as an operator. In this PR, we Introduce a `CALL_PROCEDURE` operator into `PhysicalPlan` proto. So, we could remove the `/v1/graph/{id}/query` from compiler side. However, we still need the API in server side, for SDK to use. TODO - [x] Revisit the dependency introduce by `procedure_call.cc`, including get app_base, and get session. Ideally, we shoud not only involve interfaces of ReadTransaction. -> Negative - [x] Make sure the introduce of StdStringValue is necessary. -> Removed. - [x] Finish all if-else check in `procedure_call.cc`. - [x] We need to call the procedure for each record. Could we optimize? -> Negative User now could embed the `call_proc` in a cypher query, for example ```cypher MATCH(p: person) with p.id as oid CALL k_neighbors("person", oid, 1) return label_name, vertex_oid; ``` where `k_neighbors` is a builtin procedure. Fixes #4278 --------- Co-authored-by: shirly121 <yihe.zxl@alibaba-inc.com> Co-authored-by: BingqingLyu <bingqing.lbq@alibaba-inc.com>
- Loading branch information
1 parent
542cb16
commit 6aa557c
Showing
37 changed files
with
814 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.