This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(queryRules): add connectQueryRules connector [part 1] #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts
Show resolved
Hide resolved
|
Deploy preview for react-instantsearch ready! Built with commit acff3eb https://deploy-preview-2210--react-instantsearch.netlify.com |
samouss
suggested changes
Mar 22, 2019
packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts
Show resolved
Hide resolved
packages/react-instantsearch-core/src/connectors/connectQueryRules.ts
Outdated
Show resolved
Hide resolved
samouss
approved these changes
Mar 28, 2019
francoischalifour
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st PR in the series "Merchandized Query Rules".
Summary
This creates the
connectQueryRulesconnector, responsible for handling Algolia Query Rules features.Motivation
Read RFC →
Implementation
The connector passes
userDataarray to the widget via a prop nameditems.For this React implementation, I decided not to keep the name
userDatabecause at second thought, it makes more sense to applytransformItemsto something calleditems. I will rename this data in the InstantSearch.js implementation.Connector usage
Two widgets will be based on this connector:
QueryRuleCustomDataQueryRuleContextRelated
connectQueryRulesqueryRuleCustomDataqueryRuleContext