This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 386
feat(context): migrate base connector [STEP 2] #2179
Merged
Merged
Commits on Apr 12, 2019
-
feat(context): migrate core [STEP 1]
This includes: 1. change to createConnector 2. change to createStore 3. skip failing tests 4. small nits found while coding After this to do: STEP 2: first PR with connectors (searchbox, configure, hits, pagination) STEP 3+: other connectors STEP 4: Multi index core STEP 5+: Multi index connectors STEP 6: SSR STEP 7: TypeScript completion STEP 8: documentation change
Configuration menu - View commit details
-
Copy full SHA for d428b2c - Browse repository at this point
Copy the full SHA d428b2cView commit details -
feat(context): migrate base connector [STEP 2]
This is enough changes to be able to look at the storybook without errors again (only pagination, hits, searchbox of course, and nothing multi-index) For full roadmap, see #2178
Configuration menu - View commit details
-
Copy full SHA for ff670d6 - Browse repository at this point
Copy the full SHA ff670d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4cbff3 - Browse repository at this point
Copy the full SHA d4cbff3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec8dca8 - Browse repository at this point
Copy the full SHA ec8dca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a6812e - Browse repository at this point
Copy the full SHA 3a6812eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97abdcb - Browse repository at this point
Copy the full SHA 97abdcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5df439 - Browse repository at this point
Copy the full SHA d5df439View commit details
Commits on Apr 15, 2019
-
feat(context): migrate remaining connectors [STEP 3] (#2180)
* feat(context): migrate remaining connectors [STEP 3] chore: remove wrong import test(currentRefinements): remove unused context chore(range): fix typo fix(geoSearch): gSP test: call connectors with unique context where possible feedback from review chore(infiniteHits): cleaner test refactor: migrate new connectors chore: prettier fix context default props fix TS chore: small fix * feat(context): multi-index [STEP 4] (#2181) * feat(context): migrate remaining connectors [STEP 3] * chore: remove wrong import * test(currentRefinements): remove unused context * chore(range): fix typo * fix(geoSearch): gSP * test: call connectors with unique context where possible * feedback from review * chore(infiniteHits): cleaner test * refactor: migrate new connectors * chore: prettier * fix context * default props * fix TS * chore: small fix * feat(context): multi-index [STEP 4] test(Index): re-enable and make work fix(Index): allow context to be empty initially fix(Index): onSearchParameters with correct context fix(connector): onSearchParameters with correct context chore(Index): remove else chore(Index): consistent integration test chore: clarify test chore: fix life cycle fix(ts): index context can be undefined feedback from review fix(index): correct life cycles fix TS on Index connectorWrapper chore: update snapshots * feat(context): apply multi-index [STEP 5] (#2185) Co-Authored-By: samouss <samouss@users.noreply.github.com> * feat(context): modify Index to use modern context * test(Index): re-enable and make work * fix(Index): allow context to be empty initially * fix(Index): onSearchParameters with correct context * fix(connector): onSearchParameters with correct context * chore(Index): remove else * chore(Index): consistent integration test * chore: clarify test * chore: fix life cycle * fix(ts): index context can be undefined * feedback from review * fix(index): correct life cycles * fix TS on Index * connectorWrapper * chore: update snapshots * feat(context): modify Index to use modern context * feat(context): apply multi-index [STEP 5] 1. connectMenu * connectAutoComplete * connectBreadcrumb * connectConfigure * connectGeoSearch * connectHierarchicalMenu * connectHits * connectHitsPerPage * connectInfiniteHits * connectNumericMenu * connectPagination * connectStats * connectRange * connectRefinementList * connectScrollTo * connectSearchBox * test(hierarchical): remove shadowing * connectSortBy * connectStateResults * connectToggleRefinement * fix(configure): use multi-index context * chore(configure): replace lodash.omit by spreading * test(connectors): call changing context * chore(configure): less lodash * test(configure): more detailed test * chore(test): rename ctx to instance * chore: move test * suggestions from review (mainly making multi-index tests more interesting) * chore: fix bundlesize * wrong conflict * migrate connectQueryRules * Feedback from review * fix(hitInsights): re-enable multi-index tests * feat(context): re-enable SSR [STEP 6] (#2192) * chore(ssr): unskip tests * test(ssr): better test implem * chore: remove unused file * test: more consistent mock * docs(connectors): fix spelling [STEP 8] (#2190) These are misc fixes in spelling that didn't exactly fit in a different PR remove small typo
Configuration menu - View commit details
-
Copy full SHA for cbab021 - Browse repository at this point
Copy the full SHA cbab021View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.