Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(context): migrate base connector [STEP 2] #2179

Merged
merged 8 commits into from
Apr 15, 2019

Commits on Apr 12, 2019

  1. feat(context): migrate core [STEP 1]

    This includes:
    
    1. change to createConnector
    2. change to createStore
    3. skip failing tests
    4. small nits found while coding
    
    After this to do:
    
    STEP 2: first PR with connectors (searchbox, configure, hits, pagination)
    STEP 3+: other connectors
    STEP 4: Multi index core
    STEP 5+: Multi index connectors
    STEP 6: SSR
    STEP 7: TypeScript completion
    STEP 8: documentation change
    Haroenv committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d428b2c View commit details
    Browse the repository at this point in the history
  2. feat(context): migrate base connector [STEP 2]

    This is enough changes to be able to look at the storybook without errors again (only pagination, hits, searchbox of course, and nothing multi-index)
    
    For full roadmap, see #2178
    Haroenv committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ff670d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d4cbff3 View commit details
    Browse the repository at this point in the history
  4. chore: from merge

    Haroenv committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ec8dca8 View commit details
    Browse the repository at this point in the history
  5. chore: updat bundle size

    Haroenv committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    3a6812e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    97abdcb View commit details
    Browse the repository at this point in the history
  7. feedback from review

    Haroenv committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d5df439 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. feat(context): migrate remaining connectors [STEP 3] (#2180)

    * feat(context): migrate remaining connectors [STEP 3]
    
    chore: remove wrong import
    
    test(currentRefinements): remove unused context
    
    chore(range): fix typo
    
    fix(geoSearch): gSP
    
    test: call connectors with unique context where possible
    
    feedback from review
    
    chore(infiniteHits): cleaner test
    
    refactor: migrate new connectors
    
    chore: prettier
    
    fix context
    
    default props
    
    fix TS
    
    chore: small fix
    
    * feat(context): multi-index [STEP 4] (#2181)
    
    * feat(context): migrate remaining connectors [STEP 3]
    
    * chore: remove wrong import
    
    * test(currentRefinements): remove unused context
    
    * chore(range): fix typo
    
    * fix(geoSearch): gSP
    
    * test: call connectors with unique context where possible
    
    * feedback from review
    
    * chore(infiniteHits): cleaner test
    
    * refactor: migrate new connectors
    
    * chore: prettier
    
    * fix context
    
    * default props
    
    * fix TS
    
    * chore: small fix
    
    * feat(context): multi-index [STEP 4]
    
      test(Index): re-enable and make work
    
      fix(Index): allow context to be empty initially
    
      fix(Index): onSearchParameters with correct context
    
      fix(connector): onSearchParameters with correct context
    
      chore(Index): remove else
    
      chore(Index): consistent integration test
    
      chore: clarify test
    
      chore: fix life cycle
    
      fix(ts): index context can be undefined
    
      feedback from review
    
      fix(index): correct life cycles
    
      fix TS on Index
    
      connectorWrapper
    
      chore: update snapshots
    
    * feat(context): apply multi-index [STEP 5] (#2185)
    
    Co-Authored-By: samouss <samouss@users.noreply.github.com>
    
      * feat(context): modify Index to use modern context
    
      * test(Index): re-enable and make work
    
      * fix(Index): allow context to be empty initially
    
      * fix(Index): onSearchParameters with correct context
    
      * fix(connector): onSearchParameters with correct context
    
      * chore(Index): remove else
    
      * chore(Index): consistent integration test
    
      * chore: clarify test
    
      * chore: fix life cycle
    
      * fix(ts): index context can be undefined
    
      * feedback from review
    
      * fix(index): correct life cycles
    
      * fix TS on Index
    
      * connectorWrapper
    
      * chore: update snapshots
    
      * feat(context): modify Index to use modern context
    
      * feat(context): apply multi-index [STEP 5]
    
      1. connectMenu
    
      * connectAutoComplete
    
      * connectBreadcrumb
    
      * connectConfigure
    
      * connectGeoSearch
    
      * connectHierarchicalMenu
    
      * connectHits
    
      * connectHitsPerPage
    
      * connectInfiniteHits
    
      * connectNumericMenu
    
      * connectPagination
    
      * connectStats
    
      * connectRange
    
      * connectRefinementList
    
      * connectScrollTo
    
      * connectSearchBox
    
      * test(hierarchical): remove shadowing
    
      * connectSortBy
    
      * connectStateResults
    
      * connectToggleRefinement
    
      * fix(configure): use multi-index context
    
      * chore(configure): replace lodash.omit by spreading
    
      * test(connectors): call changing context
    
      * chore(configure): less lodash
    
      * test(configure): more detailed test
    
      * chore(test): rename ctx to instance
    
      * chore: move test
    
      * suggestions from review (mainly making multi-index tests more interesting)
    
      * chore: fix bundlesize
    
      * wrong conflict
    
      * migrate connectQueryRules
    
      * Feedback from review
    
      * fix(hitInsights): re-enable multi-index tests
    
    * feat(context): re-enable SSR [STEP 6] (#2192)
    
      * chore(ssr): unskip tests
    
      * test(ssr): better test implem
    
      * chore: remove unused file
    
      * test: more consistent mock
    
    * docs(connectors): fix spelling [STEP 8] (#2190)
    
      These are misc fixes in spelling that didn't exactly fit in a different PR
    
      remove small typo
    Haroenv authored Apr 15, 2019
    Configuration menu
    Copy the full SHA
    cbab021 View commit details
    Browse the repository at this point in the history