This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat: Upgrade Client and Helper #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 0f93303 https://deploy-preview-1215--react-instantsearch.netlify.com |
Haroenv
reviewed
May 4, 2018
|
|
||
| const store1 = ism.store.getState(); | ||
| return Promise.resolve() | ||
| .then(() => {}) |
There was a problem hiding this comment.
I wonder if “await await” is allowed? I think a comment here would be useful too
samouss
reviewed
May 4, 2018
samouss
approved these changes
May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to
algoliasearch@3.27.1andalgoliasearch-helper@2.26.0, using the promisified version ofclient.search(). It is necessary for addingsearchClientsupport to React InstantSearch.I had to update the tests with a not-so-great hack because of the way we internally handle search with promises now: