docs(menu): change the text color when reaching the white background #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of changing the whole background
|
I like the idea, this is smoother that way. I would use a lighter color than the black, though. Maybe the text color of the white part? |
Yes I still find the color too strong also, @Shipow any advice? We could maybe use the last gradient tone/color :) |
|
Wooosh :D Great idea :) |
|
I think we can merge, the color can be the subject of another fix! |
vvo
pushed a commit
that referenced
this pull request
Nov 10, 2015
…ransition docs(menu): change the text color when reaching the white background
| @@ -216,3 +233,38 @@ Star.prototype.draw = function() { | |||
| context.fill(); | |||
| context.restore(); | |||
| }; | |||
|
|
|||
| // http://stackoverflow.com/questions/14012766/detecting-whether-two-divs-overlap | |||
| function overlap($div1, $div2) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After