feat(numericRefinementList) #454
Conversation
| @@ -35,7 +35,14 @@ class RefinementList extends React.Component { | |||
| [this.props.cssClasses.active]: facetValue.isRefined | |||
| }); | |||
|
|
|||
| let key = facetValue[this.props.facetNameKey] + '/' + facetValue.isRefined + '/' + facetValue.count; | |||
| let key = facetValue[this.props.facetNameKey]; | |||
| if (facetValue.count !== undefined) { | |||
There was a problem hiding this comment.
Bad copy/paste, you want to test facetValue. isRefined here.
|
I did 2 comments, but overall very nice @maxiloc 👍 |
|
Wait what is docs/js/instantsearch.js? It looks like a dist/ you commited. Remove and add it to gitignore if relevant, we tried no to have dist files. |
Ah right, that was a temporary; need to be removed. |
…g refinementList component
maxiloc
force-pushed
the
new-numeric-refinement-list-3
branch
from
9e6f82a
to
a29e9c7
Compare
|
I rebased with the 3 fix |
| @@ -12453,4 +12453,4 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Weird I did not touch this file,
Should I add the newline again ?
There was a problem hiding this comment.
No we are good, the next shrinkwrap will just do it
|
Looks..Like.. LGTM! |
🚀
|
@redox I am good here, since you added comments I'll let you merge, again awesome feature :D |
|
👍 |
This avoids `@babel/preset-env` compatibility issue.
Created a new PR, did some mess with the first one.