feat(headerFooter): Only add markup if a template is defined #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #381 merged first. |
Fixes #370 BREAKING CHANGE: The `<div class="ais-header">` and `<div class="ais-footer">` markup is only added when a `templates.{header,footer}` is passed.
pixelastic
force-pushed
the
feat/header-footer-370
branch
from
61e5008
to
7a2d22d
Compare
|
I've just rebased, this is ready too. |
|
@pixelastic If you need a new version after this one is merged you can do it, npm run release |
vvo
pushed a commit
that referenced
this pull request
Oct 29, 2015
feat(headerFooter): Only add markup if a template is defined
|
I don't really need a new version myself as I'm testing with the local webpack bundle, but I can release if anyone need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
BREAKING CHANGE: The
<div class="ais-header">and<div class="ais-footer">markup is only added whena
templates.{header,footer}is passed.