fix(types): improve types for voiceSearch #3778

eunjae-lee · 2019-05-15T12:53:59Z

Summary

This makes the types of the two things non-optional.

The related discussion is here

eunjae-lee · 2019-05-15T12:54:57Z

I'm making the change here first before React. @samouss

algobot · 2019-05-15T12:56:37Z

Deploy preview for instantsearchjs ready!

Built with commit 9788d81

## [3.5.1](v3.5.0...v3.5.1) (2019-05-20) ### Bug Fixes * **types:** improve types for voiceSearch ([#3778](#3778)) ([ed2d61a](ed2d61a)) * **types:** update UiState type ([#3777](#3777)) ([36e3a3d](36e3a3d)) * **voiceSearch:** remove event listeners on dispose ([#3779](#3779)) ([0e988cc](0e988cc)) ### Reverts * chore(build): remove PropTypes from builds ([#3697](#3697)) ([#3776](#3776)) ([1e6be79](1e6be79))

Eunjae Lee added 2 commits May 15, 2019 14:47

fix(types): make isSpeechFinal non-optional boolean

eaa0b14

fix(types): make transcript non-optional string

e2717c1

eunjae-lee requested a review from a team May 15, 2019 12:54

ghost requested review from Haroenv and tkrugg and removed request for a team May 15, 2019 12:54

chore(voiceSearch): assign an empty string if no transcript

9788d81

samouss approved these changes May 15, 2019

View reviewed changes

eunjae-lee merged commit ed2d61a into develop May 15, 2019

eunjae-lee deleted the fix/types-voice-search branch May 15, 2019 14:07

Provide feedback