Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove unused Without type #3694

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

francoischalifour
Copy link
Member

The Without type is not used and conflicts with Omit.

@francoischalifour francoischalifour requested a review from a team April 16, 2019 08:18
@algobot
Copy link
Contributor

algobot commented Apr 16, 2019

Deploy preview for instantsearchjs ready!

Built with commit 8cfd95d

https://deploy-preview-3694--instantsearchjs.netlify.com

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is unused

@francoischalifour francoischalifour merged commit 656d000 into develop Apr 16, 2019
@francoischalifour francoischalifour deleted the fix/types-remove-Without branch April 16, 2019 08:47
tkrugg added a commit that referenced this pull request Apr 17, 2019
# [3.4.0](v3.3.0...v3.4.0) (2019-04-17)

### Bug Fixes

* **storybook:** fix Hierarchical menu separator in Breadcrumb story ([#3695](#3695)) ([b3bf8ac](b3bf8ac))
* **tools:** use commonjs in bump-package-version.js ([#3699](#3699)) ([6a6dbe1](6a6dbe1))
* **types:** fix wrong typing in getWidgetState ([#3693](#3693)) ([b3c2154](b3c2154))
* **types:** remove unused Without type ([#3694](#3694)) ([656d000](656d000))

### Features

* **infiniteHits:** add previous button ([#3675](#3675)) ([2e6137b](2e6137b))
* **Insights:** Insights inside Instantsearch ([#3598](#3598)) ([387f41f](387f41f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants