Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(normalizeRefinement): remove boolean values passed to _objectSpread in normalizeRefinement #3672

Merged
merged 2 commits into from
Apr 11, 2019

Commits on Apr 10, 2019

  1. fix(normalizeRefinement): remove boolean values passed to _objectSpre…

    …ad in normalizeRefinement
    
    _objectSpread polyfill calls Object.keys() under the hood which on IE11
    does not support anything other than objects.
    
    Reason: change in spec
    
    ES5: https://www.ecma-international.org/ecma-262/5.1/#sec-15.2.3.14
    
    > If the Type(O) is not Object, throw a TypeError exception.
    
    ES6: https://www.ecma-international.org/ecma-262/6.0/#sec-object.keys
    
    Uses ToObject, which supports booleans
    
    > Return a new Boolean object whose [[BooleanData]] internal slot is set to the value of argument. See 19.3 for a description of Boolean objects
    tkrugg committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    f130a95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2beeadb View commit details
    Browse the repository at this point in the history