-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(voiceSearch): add connector and widget #3601
Conversation
Deploy preview for instantsearchjs ready! Built with commit 71a17e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things I noted but looking good.
It's cool to see this feature landing.
…earch-as-you-speak
This reverts commit 63fcde1.
src/connectors/voice-search/__tests__/connectVoiceSearch-test.js
Outdated
Show resolved
Hide resolved
src/connectors/voice-search/__tests__/connectVoiceSearch-test.js
Outdated
Show resolved
Hide resolved
src/connectors/voice-search/__tests__/connectVoiceSearch-test.js
Outdated
Show resolved
Hide resolved
src/connectors/voice-search/__tests__/connectVoiceSearch-test.js
Outdated
Show resolved
Hide resolved
src/connectors/voice-search/__tests__/connectVoiceSearch-test.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
Co-Authored-By: eunjae-lee <karis612@gmail.com>
…s into poc/voice-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the branch is updated we should be able to move forward with this.
# [3.5.0](v3.4.0...v3.5.0) (2019-05-14) ### Bug Fixes * **hitsPerPage:** improve warning for missing state value ([#3707](#3707)) ([93d8432](93d8432)) * **numericMenu:** prevent refinement reset on checked radio click ([#3749](#3749)) ([e4a6e75](e4a6e75)) * **rangeSlider:** round the slider pit value ([#3758](#3758)) ([6edee3e](6edee3e)), closes [#2904](#2904) * **types:** improve UiState types ([#3763](#3763)) ([e8ea57b](e8ea57b)) * **voice:** import correct noop ([#3766](#3766)) ([6a80422](6a80422)) ### Features * **voiceSearch:** add connector and widget ([#3601](#3601)) ([21e4d81](21e4d81))
This POC shows an implementation of voice search widget on instantsearch.js.
See more: https://github.com/algolia/instantsearch-rfcs/pull/15
This PR is a draft, not intended to be merged right away.