-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(panel): append panel body as a child element #3561
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7bb7bb5
fix(panel): append panel body as a child element
francoischalifour 8d323fd
fix(panel): update stories
francoischalifour 2463055
test(panel): test inner widget lifecycle
francoischalifour 14f62b6
test(Panel): refactor way to get default props
francoischalifour b59541c
test(Panel): store cssClasses in variable
francoischalifour e6057c3
test(panl): use toWarnDev
francoischalifour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,37 +21,40 @@ storiesOf('Panel', module) | |
}) | ||
) | ||
.add( | ||
'with ratingMenu', | ||
'with range input', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated these stories because they conflicted with the playground. |
||
withHits(({ search, container, instantsearch }) => { | ||
search.addWidget( | ||
instantsearch.widgets.panel({ | ||
templates: { | ||
header: ({ results }) => | ||
`Header ${results ? `| ${results.nbHits} results` : ''}`, | ||
header: 'Price', | ||
footer: 'Footer', | ||
}, | ||
hidden: ({ results }) => results.nbHits === 0, | ||
})(instantsearch.widgets.ratingMenu)({ | ||
})(instantsearch.widgets.rangeInput)({ | ||
container, | ||
attribute: 'price', | ||
}) | ||
); | ||
}) | ||
) | ||
.add( | ||
'with menu', | ||
'with range slider', | ||
withHits(({ search, container, instantsearch }) => { | ||
search.addWidget( | ||
instantsearch.widgets.panel({ | ||
templates: { | ||
header: ({ results }) => | ||
`Header ${results ? `| ${results.nbHits} results` : ''}`, | ||
header: 'Price', | ||
footer: 'Footer', | ||
}, | ||
hidden: ({ results }) => results.nbHits === 0, | ||
})(instantsearch.widgets.menu)({ | ||
})(instantsearch.widgets.rangeSlider)({ | ||
container, | ||
attribute: 'brand', | ||
attribute: 'price', | ||
tooltips: { | ||
format(rawValue) { | ||
return `$${Math.round(rawValue).toLocaleString()}`; | ||
}, | ||
}, | ||
}) | ||
); | ||
}) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the indirection created by the
renderer
. We can avoid to return a new function from the renderer and provide the full list of argument each time call the function. We do this in widgets because we don't have the control on therender
call (which can be avoided anyway). Here we do have the control (see below). We can do it in another PR.