Update search-box type #3527
Closed
Update search-box type #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change <input> type to search
|
Deploy preview for instantsearchjs ready! Built with commit 417c436 |
|
This is actually already fixed in #3489. Unfortunately your fix isn't complete however, for it to show as Thanks for this PR, but it won't be needed with the other existing PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type to search
Summary
A customer complained that the type is text and not search. type='search' makes the CTA button on iOS keyboards read 'search' instead of 'done'. I noticed in React IS this is already the case.