Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connectBreadcrumb): ensure that data is an array #3067

Merged
merged 1 commit into from
Aug 17, 2018
Merged

fix(connectBreadcrumb): ensure that data is an array #3067

merged 1 commit into from
Aug 17, 2018

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Aug 17, 2018 •
edited
Loading

Summary

The current implementation of connectBreadcrumb never checked that the facetValues.data attribute is an array. But it might happen that this value is null (in case of no results for example). Currently the connector throws an error, this PR fixes this issue.

Before

before

After

after

You can test the widget in DevNovel.

@samouss samouss requested a review from a team August 17, 2018 11:40
@algobot
Copy link
Contributor

algobot commented Aug 17, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 4ef0ca3

https://deploy-preview-3067--algolia-instantsearch.netlify.com

Haroenv
Haroenv approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, a bit surprising that it used to be null, is that coming from the engine or the helper or something?

@bobylito bobylito merged commit 759f709 into develop Aug 17, 2018
@bobylito bobylito deleted the fix/connect-breadcrumb-prepare branch August 17, 2018 12:16
bobylito pushed a commit that referenced this pull request Aug 17, 2018
v2.10.1
8b96e4e 
<a name=2.10.1></a>
## [2.10.1](v2.10.0...v2.10.1) (2018-08-17)

### Bug Fixes

* **connectBreadcrumb:** ensure that data is an array ([#3067](#3067)) ([759f709](759f709))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobylito bobylito bobylito approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samouss @algobot @bobylito @Haroenv