fix: pagination padding #2866
Merged
fix: pagination padding #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Apr 6, 2018
bobylito
approved these changes
Apr 6, 2018
|
Don't know why the status aren't reported... The CI is complete though. |
|
@samouss Ok let's merge :) |
bobylito
pushed a commit
that referenced
this pull request
Apr 9, 2018
<a name=2.7.0></a> # [2.7.0](v2.6.3...v2.7.0) (2018-04-09) ### Bug Fixes * pagination padding ([#2866](#2866)) ([e8c58cc](e8c58cc)) * **geosearch:** avoid reset map when it already moved ([#2870](#2870)) ([f171b8a](f171b8a)) * **removeWidget:** check for widgets.length on next tick ([#2831](#2831)) ([7e639d6](7e639d6)) ### Features * **connetConfigure:** add a connector to create a connector widget ([8fdf752](8fdf752)) * **routing:** provide a mechanism to synchronize the search ([#2829](#2829)) ([75b2ca3](75b2ca3)), closes [#2849](#2849) [#2849](#2849) * **size:** add sideEffects false to package.json ([#2861](#2861)) ([f5d1ab1](f5d1ab1)), closes [#2859](#2859)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #2864
I also removed the default value for the padding in the widget since we already have it in the connector. No need to have this information twice.
Before
After
See the results on DevNovel.