Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(removeWidget): check for widgets.length on next tick #2831

Merged
merged 1 commit into from
Apr 5, 2018
Merged

fix(removeWidget): check for widgets.length on next tick #2831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/lib/InstantSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,16 @@ Usage: instantsearch({
}
});

// no need to trigger a search if we don't have any widgets left
if (this.widgets.length > 0) {
this.helper.search();
}
// If there's multiple call to `removeWidget()` let's wait until they are all made
// and then check for widgets.length & make a search on next tick
//
// This solves an issue where you unmount a page and removing widget by widget
setTimeout(() => {
// no need to trigger a search if we don't have any widgets left
if (this.widgets.length > 0) {
this.helper.search();
}
}, 0);
}

/**
Expand Down