feat(headerFooter): Add BEM classes to header and footer #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All headers and footers will now receive a `ais-header` and
`ais-footer` class. Additional classes can also be added through
`cssClasses.{root,header,body,footer}`.
It means that it is no longer necessary to pass a full HTML div in the
`templates.header`. One can simply pass the header text content and
pass a `cssClasses.header` custom class.
So far only the `refinementList` widgets correctly add the
`ais-widgetname-header`/`ais-widgetname-footer` classes. I'll update
the other widgets once this gets merged.
Fixes #259
Relies on #264 being
merged first
pixelastic
force-pushed
the
feat/header-footer-bem
branch
from
e65d07c
to
9e9d438
Compare
|
LGTM |
vvo
pushed a commit
that referenced
this pull request
Oct 16, 2015
feat(headerFooter): Add BEM classes to header and footer
aymeric-giraudet
pushed a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All headers and footers will now receive a
ais-headerandais-footerclass. Additional classes can also be added throughcssClasses.{root,header,body,footer}.It means that it is no longer necessary to pass a full HTML div in the
templates.header. One can simply pass the header text content andpass a
cssClasses.headercustom class.So far only the
refinementListwidgets correctly add theais-widgetname-header/ais-widgetname-footerclasses. I'll updatethe other widgets once this gets merged.
Fixes #259
Relies on #264 being
merged first