chore(security): remove public tokens #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following security reports, removing public tokens for saucelabs and argos. For Saucelabs we are now using https://docs.travis-ci.com/user/jwt which is the recommended way to have external contributors PRs working (read documentation on travis). For Argos jwt is not implemented so it will just be disabled, we need to be careful while reviewing for now (same setup as react-instantsearch).
|
Deploy preview ready! Built with commit 93710c4 https://deploy-preview-2633--algolia-instantsearch.netlify.com |
Haroenv
approved these changes
Dec 21, 2017
vvo
commented
Dec 21, 2017
| @@ -14,19 +16,16 @@ branches: | |||
| - master | |||
| - develop | |||
| - feat/instantsearch.js/v2 | |||
| - /^feat\/\d+\.\d+$/ | |||
| - "/^feat\\/\\d+\\.\\d+$/" | |||
There was a problem hiding this comment.
was done by travis command line automatically
|
#securityLove Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following security reports, removing public tokens for saucelabs and
argos.
For Saucelabs we are now using https://docs.travis-ci.com/user/jwt which
is the recommended way to have external contributors PRs working (read
documentation on travis).
For Argos jwt is not implemented so it will just be disabled, we need to
be careful while reviewing for now (same setup as react-instantsearch).