-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/widgets dispose #2610
Merged
Merged
Fix/widgets dispose #2610
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b771e26
fix(hierarchicalMenu): check is facet refined first
iam4x 02f2bcd
fix(connectMenu): check facet refined is applied before removing it
iam4x 5531667
refactor(dispose): initialize with `state = nextState`
iam4x 07b0330
Merge branch 'develop' into fix/widgets-dispose
bobylito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,9 +233,20 @@ export default function connectMenu(renderFn, unmountFn) { | |
dispose({ state }) { | ||
unmountFn(); | ||
|
||
const nextState = state | ||
.removeHierarchicalFacetRefinement(attributeName) | ||
.removeHierarchicalFacet(attributeName); | ||
let nextState; | ||
|
||
if (state.isHierarchicalFacetRefined(attributeName)) { | ||
nextState = state.removeHierarchicalFacetRefinement(attributeName); | ||
} | ||
|
||
nextState = (nextState || state).removeHierarchicalFacet(attributeName); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you initialize |
||
|
||
if ( | ||
nextState.maxValuesPerFacet === limit || | ||
(showMoreLimit && nextState.maxValuesPerFacet === showMoreLimit) | ||
) { | ||
nextState.setQueryParameters('maxValuesPerFacet', undefined); | ||
} | ||
|
||
return nextState; | ||
}, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you initialize
nextState
withstate
at l.200 you don't need to usenextState || state
.