Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InstantSearch.dispose): dont call URLSync.getConfiguration #2604

Merged
merged 1 commit into from
Nov 27, 2017
Merged

fix(InstantSearch.dispose): dont call URLSync.getConfiguration #2604

merged 1 commit into from
Nov 27, 2017

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented Nov 27, 2017

Case:

If you have urlSync: true and refinement for a widget you dispose in the URL, the search will crash because calling URLSync.getConfiguration() will add back the removed refinement found in the URL for the next search.

Fix:

Don't call URLSync.getConfiguration() when a widget is disposed 👍

@iam4x iam4x requested a review from bobylito November 27, 2017 12:49
@algobot
Copy link
Contributor

algobot commented Nov 27, 2017

Deploy preview ready!

Built with commit dc318a3

https://deploy-preview-2604--algolia-instantsearch.netlify.com

@iam4x iam4x mentioned this pull request Nov 27, 2017
Merged
bobylito
bobylito approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@bobylito bobylito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bobylito bobylito merged commit 3234b12 into feat/2.3 Nov 27, 2017
@bobylito bobylito deleted the fix-removewidget-with-url-sync-widget branch November 27, 2017 17:36
bobylito pushed a commit that referenced this pull request Nov 30, 2017
v2.3.0
7d0d9e5 
<a name=2.3.0></a>
# [2.3.0](v2.3.0-beta.7...v2.3.0) (2017-11-30)

### Bug Fixes

* **InstantSearch.dispose:** dont call  of URLSync widget ([#2604](#2604)) ([3234b12](3234b12))

### Features

* **core:** provide information about stalled search to widgets ([#2569](#2569)) ([d104be1](d104be1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobylito bobylito bobylito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iam4x @algobot @bobylito