fix(connectors): prefer wrappers over bind #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using bind, which will be applied at each init. This is ok for one time mount, but since we can mount and unmount dynamically now, it's a problem.
|
Deploy preview ready! Built with commit a5ed7d0 https://deploy-preview-2575--algolia-instantsearch.netlify.com |
|
Hey 👋 looks like a good call. You still need to run prettier on this PR :) |
Well the only problem is that I haven't touched the files failing... |
|
I need to fix the tests here :/ Apparently we're testing the internals on the widget side and of course this PR changes the internal. |
Haroenv
reviewed
Nov 15, 2017
| @@ -158,13 +158,15 @@ export default function connectPriceRanges(renderFn, unmountFn) { | |||
| }, | |||
|
|
|||
| init({ helper, instantSearchInstance }) { | |||
| this._refine = this._refine.bind(this, helper); | |||
| this.refine = (...opts) => { | |||
| this._refine(helper, ...opts); | |||
There was a problem hiding this comment.
refine only has two arguments, what about not spreading?
There was a problem hiding this comment.
That's indeed preferable to avoid spreading if we know the number of arguments 👍
Haroenv
reviewed
Nov 16, 2017
iam4x
approved these changes
Nov 16, 2017
|
Happy to take 5 minutes and go over the code to explain if you want @Haroenv |
bobylito
pushed a commit
that referenced
this pull request
Nov 16, 2017
<a name=2.3.0-beta.6></a> # [2.3.0-beta.6](v2.3.0-beta.5...v2.3.0-beta.6) (2017-11-16) ### Bug Fixes * **connectors:** prefer wrappers over bind ([#2575](#2575)) ([f8e0e00](f8e0e00))
bobylito
pushed a commit
that referenced
this pull request
Nov 20, 2017
<a name=2.3.0-beta.7></a> # [2.3.0-beta.7](v2.2.5...v2.3.0-beta.7) (2017-11-20) <a name=2.3.0-beta.6></a> # [2.3.0-beta.6](v2.3.0-beta.5...v2.3.0-beta.6) (2017-11-16) ### Bug Fixes * **connectors:** prefer wrappers over bind ([#2575](#2575)) ([f8e0e00](f8e0e00)) <a name=2.3.0-beta.5></a> # [2.3.0-beta.5](v2.2.4...v2.3.0-beta.5) (2017-11-16) ### Features * **core:** InstantSearch hot remove/add widgets ([#2384](#2384)) ([cfc1710](cfc1710)) <a name=2.3.0-beta.3></a> # [2.3.0-beta.3](v2.3.0-beta.2...v2.3.0-beta.3) (2017-10-25) ### Bug Fixes * **connectors:** export as well ([0b78d75](0b78d75)) ### Features * **refinementList:** add escapeFacetHits parameter ([#2507](#2507)) ([9b1b7ee](9b1b7ee)) <a name=2.3.0-beta.2></a> # [2.3.0-beta.2](v2.2.1...v2.3.0-beta.2) (2017-10-24) ### Bug Fixes * **connectHierarchicalMenu:** do not return if facet not set ([#2521](#2521)) ([26e99fb](26e99fb)) ### Features * **breadcrumb:** Add the breadcrumb widget ([#2451](#2451)) ([11d78f0](11d78f0)), closes [#2299](#2299) * **connectRange:** round the range based on precision ([#2498](#2498)) ([d4df45d](d4df45d)) * **rangeInput:** add rangeInput widget ([#2440](#2440)) ([7916d16](7916d16))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using bind, which will be applied at each init. This
is ok for one time mount, but since we can mount and unmount dynamically
now, it's a problem.