-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): provide information about stalled search to widgets #2569
Merged
Merged
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
51c7df7
feat(core): the core provides information about stalled search
a3a5947
feat(searchbox): implements a loading indicator
b95c3b0
chore(lint): fix prettier and eslint check
0e37c0c
Merge branch 'develop' into poc/central-loading-state
bobylito 75d7cf2
Merge branch 'develop' into poc/central-loading-state
vvo 59fdbaf
feat(core): add option to configure stalled search delay
1d0aa21
Merge branch 'poc/central-loading-state' of github.com:algolia/instan…
6821e09
feat(searchbox): add options to set a loading indicator
4ecf773
Merge branch 'develop' into poc/central-loading-state
a4d4b89
chore: update test to match the lib changes
ca4ed04
chore(search-box-test): remove sinon
852e4ab
chore(connectSearchBox): remove sinon from test
d5398f5
chore(doc): add isStalledSearch on connectSearchBox rendering options
7a450b1
chore(validation): merge commit length should not be checked
ea2d14f
test(core): test new render step with stalled search
16475ab
Merge branch 'develop' into poc/central-loading-state
vvo 0cd59a5
Merge branch 'develop' into poc/central-loading-state
vvo e3a9940
chore(searchbox): test with input tag container
dc5ee62
chore(doc): fix inconsistencies and add details
5583d18
chore(searchbox): use `.ais-stalled-search` and fix use of input
7e9157e
chore(doc): fix content
36c5dcd
Merge branch 'feat/2.3' into poc/central-loading-state
bobylito 737d28e
chore: merge with 2.3, update snapshot
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this CSS class name follow ais- conventions? And be documented somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes sure. Also it doesn't work if you use an input as container :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe document that part, but I won't be surprised as a dev for it not to be supported.