fix(refinementList): fix facet exhaustivity check #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check depends on wether or not there is another widget setting the max value per facet to a bigger value, we can't be sure that if there is the same number of items than the limit that it is exhaustive. Fixes the other part of #2552
|
Deploy preview ready! Built with commit 9155da2 https://deploy-preview-2554--algolia-instantsearch.netlify.com |
|
Test on CI bailed out because prettier wasn't followed; |
|
Nice catch, I didn't thought it would have come from here 👍 |
iam4x
approved these changes
Nov 6, 2017
bobylito
pushed a commit
that referenced
this pull request
Nov 7, 2017
<a name=2.2.3></a> ## [2.2.3](v2.2.2...v2.2.3) (2017-11-07) ### Bug Fixes * **connectRefinementList:** add label to searched items ([#2553](#2553)) ([ec810fa](ec810fa)) * **refinementList:** fix facet exhaustivity check ([#2554](#2554)) ([0f1bf08](0f1bf08)), closes [#2552](#2552) * **theme:** searchbar should have normal size input ([#2545](#2545)) ([50d99f0](50d99f0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check depends on whether or not there is another widget setting the
max value per facet to a bigger value, we can't be sure that if there is
the same number of items than the limit that it is exhaustive.
Fixes the other part of #2552