fix(url-sync): make URLSync consistent even if search is tampered #2530

bobylito · 2017-10-28T10:12:57Z

When there is a search function that prevents the initial rendering,
the first actual change should be able to update the URL.

Fix #2523

When there is a search function that prevents the initial rendering, the first actual change should be able to update the URL. Fix #2523

bobylito · 2017-10-28T10:14:44Z

The dev-novel should be updated in order to be able to see the action logger :)

algobot · 2017-10-28T10:16:16Z

Deploy preview ready!

Built with commit 392927e

https://deploy-preview-2530--algolia-instantsearch.netlify.com

algobot · 2017-10-28T10:18:54Z

Deploy preview ready!

Built with commit 568dc56

https://deploy-preview-2530--algolia-instantsearch.netlify.com

samouss

LGTM 👌

Just need to run prettier & clean a forgotten console.log

samouss · 2017-10-28T13:28:56Z

src/lib/url-sync.js

+
+      const initStateQs = this.getQueryString(this.initState);
+      const stateQs = this.getQueryString(state);
+      console.log(initStateQs, stateQs);


Clean the console.log

bobylito · 2017-10-30T09:55:48Z

I added a command to run eslint with prettier because I don't like autoreformat and it adds a dependency in the editor.

bobylito · 2017-10-30T09:58:21Z

I updated the code @samouss :)

bobylito · 2017-10-30T10:08:15Z

Thanks for the review @samouss I'm just waiting for the next version of dev-novel

Alex S added 2 commits October 28, 2017 12:08

chore(stories): make story for #2523

ea47396

fix(url-sync): make URLSync consistent even if search is tampered

392927e

When there is a search function that prevents the initial rendering, the first actual change should be able to update the URL. Fix #2523

bobylito requested review from iam4x and samouss October 28, 2017 10:12

Merge branch 'develop' into fix/2523

3e26fba

samouss reviewed Oct 28, 2017

View reviewed changes

Alex S and others added 3 commits October 30, 2017 10:48

chore(script): add command for fixing prettier for all files

7ec688a

chore: apply prettier

6986972

Merge branch 'develop' into fix/2523

d810284

samouss approved these changes Oct 30, 2017

View reviewed changes

Merge branch 'develop' into fix/2523

568dc56

bobylito merged commit 1ba9f31 into develop Oct 30, 2017

bobylito deleted the fix/2523 branch October 31, 2017 14:52

austin-roberts mentioned this pull request Nov 7, 2017

urlSync pushes new history state on load if searchFunction is used #2557

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(url-sync): make URLSync consistent even if search is tampered #2530

fix(url-sync): make URLSync consistent even if search is tampered #2530

bobylito commented Oct 28, 2017

bobylito commented Oct 28, 2017

algobot commented Oct 28, 2017

algobot commented Oct 28, 2017 •

edited

Loading

samouss left a comment

samouss Oct 28, 2017 •

edited

Loading

bobylito commented Oct 30, 2017

bobylito commented Oct 30, 2017

bobylito commented Oct 30, 2017

fix(url-sync): make URLSync consistent even if search is tampered #2530

fix(url-sync): make URLSync consistent even if search is tampered #2530

Conversation

bobylito commented Oct 28, 2017

bobylito commented Oct 28, 2017

algobot commented Oct 28, 2017

algobot commented Oct 28, 2017 • edited Loading

samouss left a comment

Choose a reason for hiding this comment

samouss Oct 28, 2017 • edited Loading

Choose a reason for hiding this comment

bobylito commented Oct 30, 2017

bobylito commented Oct 30, 2017

bobylito commented Oct 30, 2017

algobot commented Oct 28, 2017 •

edited

Loading

samouss Oct 28, 2017 •

edited

Loading