Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(publish): fix dev dep install on docgen when publishing #2467

Merged
merged 4 commits into from
Oct 12, 2017
Merged

chore(publish): fix dev dep install on docgen when publishing #2467

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
753c636
chore(publish): fix dev dependencies when publishing doc
Oct 10, 2017
3f0ea26
chore(publish): install dependencies before building is.js for doc
Oct 10, 2017
fee6dfd
chore(publish): use dev dependencies for building is.js
bobylito Oct 10, 2017
7bb9f1b
Merge branch 'develop' into fix/build-devdep-docgen
vvo Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/docs/build-dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
#! /usr/bin/env bash

set -ev # exit when error
set -e # exit when error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for information, what is v stand for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verbose, every line of the script will be also written on the output (not just the effect, but also the line itself).

doc: http://tldp.org/LDP/abs/html/options.html (not easy to find!)


NODE_ENV=${NODE_ENV:-development}
VERSION=preview-$(json version < package.json)

# Build instantsearch.js library
yarn install --production=false
NODE_ENV=production VERSION=${VERSION} yarn run build

# Build the documentation
Expand All @@ -14,7 +15,8 @@ mkdir -p docs

(
cd docgen
yarn install && NODE_ENV=$NODE_ENV yarn run build
yarn install --production=false
NODE_ENV=$NODE_ENV yarn run build
)


Expand All @@ -33,4 +35,4 @@ cp dist/* docs/v2/
NODE_ENV=production webpack --config dev/webpack.config.js

# Move dev-novel to website-root
mv dev/dist docs/v2/dev-novel
mv dev/dist docs/v2/dev-novel