Fix edge case slider #2336
Merged
Fix edge case slider #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam4x
force-pushed
the
fix-edge-case-slider
branch
from
f878b92
to
2fa927c
Compare
bobylito
reviewed
Sep 14, 2017
src/components/Slider/Slider.js
Outdated
| @@ -28,7 +28,7 @@ class Slider extends Component { | |||
| }; | |||
|
|
|||
| get isDisabled() { | |||
| return this.props.min === this.props.max; | |||
| return this.props.min === this.props.max || this.props.min > this.props.max; | |||
|
Deploy preview ready! Built with commit f878b92 https://deploy-preview-2336--algolia-instantsearch.netlify.com |
|
Deploy preview ready! Built with commit c328df5 https://deploy-preview-2336--algolia-instantsearch.netlify.com |
iam4x
force-pushed
the
fix-edge-case-slider
branch
from
2fa927c
to
c328df5
Compare
|
I went ahead of myself and this is of course approved change :) |
bobylito
pushed a commit
that referenced
this pull request
Sep 14, 2017
<a name=2.1.4></a> ## [2.1.4](v2.1.3...v2.1.4) (2017-09-14) ### Bug Fixes * **release-script:** Add the generation of changelog for the release ([#2333](#2333)) ([9a2f70b](9a2f70b)) * **slider:** edge case when min > max ([#2336](#2336)) ([8830ab0](8830ab0)) * **slider:** Fix range slider dev env ([#2320](#2320)) ([e78de70](e78de70)) * **slider:** use algolia fork of rheostat ([#2335](#2335)) ([9eae009](9eae009))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2331