fix(CONTRIBUTING): remove section about beta releases #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have beta releases yet (see the [script](https://github.com/algolia/instantsearch.js/blob/develop/scripts/release.sh#L85-L92) and #2056), so the contributing section shouldn't be added yet. We will put this back when -b works, and we've found a strategy for making it work with jsDeliver
|
Deploy preview ready! Built with commit da91953 https://deploy-preview-2109--algolia-instantsearch.netlify.com |
|
Actually that would be great if we could do a beta release :) |
|
Yes, but it's not possible for now because of jsDeliver, it will always take the latest release, regardless of git tag... |
|
Would it be possible to beta release in npm only? (I've had the issue you mention before :/) What if we push explicitly to jsDeliver, and do not rely on npm anymore for that? |
|
I would be okay with not using jsDeliver anymore, and using unpkg like in react-instantsearch |
bobylito
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't have beta releases yet (see the script and #2056), so the contributing section shouldn't be added yet.
We will put this back when
-bworks, and we've found a strategy for making it work with jsDeliverResult
Remove the beta section in CONTRIBUTING for now