Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoweredBy: extract its hiding capabilities #195

Merged
merged 1 commit into from
Oct 9, 2015

Conversation

redox
Copy link
Contributor

@redox redox commented Oct 9, 2015

It must not be the responsability of the PoweredBy component to
show/hide itself. Fix #189

@bobylito
Copy link
Contributor

bobylito commented Oct 9, 2015

LGTM!

@bobylito
Copy link
Contributor

bobylito commented Oct 9, 2015

The commit message doesn't follow our policy

Can you update @redox ? Thanks :)

It must not be the responsability of the PoweredBy component to
show/hide itself. Fix #189
@redox redox force-pushed the feature/powered-by-display-none-improvements branch from 65d12af to f5fa9ee Compare October 9, 2015 07:45
bobylito added a commit that referenced this pull request Oct 9, 2015
…improvements

PoweredBy: extract its hiding capabilities
@bobylito bobylito merged commit da1bf86 into develop Oct 9, 2015
@vvo vvo removed the in progress label Oct 9, 2015
@bobylito bobylito deleted the feature/powered-by-display-none-improvements branch October 9, 2015 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants