fix(sffv-searchbox): update classnames to avoid conflicts #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were reusing the default class names from @Shipow searchbox generator. If a user were to use those, it would break their implementation. Move to something more specific, `sbx-sffv` instead of `sbx-custom`.
bobylito
force-pushed
the
fix/sffv-searchbox-classname
branch
from
42a26e1
to
eb07da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for instantsearch.js
We were reusing the default class names from @Shipow searchbox
generator. If a user were to use those, it would break their
implementation. Move to something more specific,
sbx-sffvinstead of
sbx-custom.