Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Slider): default precision to 2 #1279

Merged
merged 2 commits into from
Sep 14, 2016
Merged

fix(Slider): default precision to 2 #1279

merged 2 commits into from
Sep 14, 2016

Conversation

vvo
Copy link
Contributor

@vvo vvo commented Sep 13, 2016

No description provided.

vvo added 2 commits September 12, 2016 11:51
chore(build): force rebuild, was lost because bad travis config
a735543
fix(Slider): default precision to 2
afe3f0a 
There was currently no precision formatting within the Slider.

While sometime the computed interpolated value for the slider would be
23.0000003 we would refine Algolia with that and this would end up
showing in other widgets.

So we default to precision 2 within all number formatting within the
slider by default.

fixes
#1254 (comment)
and linked to https://github.com/algolia/algoliasearch-
magento/issues/546
@algobot
Copy link
Contributor

algobot commented Sep 13, 2016

By analyzing the blame information on this pull request, we identified @redox, @maxiloc and @bobylito to be potential reviewers

@bobylito
Copy link
Contributor

Looks good!

@vvo vvo merged commit 552b9ea into develop Sep 14, 2016
@vvo vvo deleted the fix/slider-default-formatting branch September 14, 2016 11:56
@vvo vvo removed the in progress label Sep 14, 2016
vvo pushed a commit that referenced this pull request Sep 14, 2016
v1.8.8
f5a3b44 
<a name="1.8.8"></a>
## [1.8.8](v1.8.6...v1.8.8) (2016-09-14)

### Bug Fixes

* **numericSelector:** do not change state on init (#1280) ([cf27db3](cf27db3)), closes [#1253](#1253)
* **Slider:** default precision to 2 (#1279) ([552b9ea](552b9ea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvo @algobot @bobylito