fix(searchBox): update helper query on every keystroke #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @maxiloc, @bobylito and @pixelastic to be potential reviewers |
vvo
pushed a commit
that referenced
this pull request
Jul 11, 2016
<a name="1.6.2"></a> ## [1.6.2](v1.6.1...v1.6.2) (2016-07-11) ### Bug Fixes * **paginationLink:** it's aria-label not ariaLabel (#1125) ([70a190c](70a190c)) * **pricesRange:** fill the form according to the current refinement (#1126) ([12ebde7](12ebde7)), closes [#1009](#1009) * **rangeSlider:** handles now support stacking (#1129) ([ad394d3](ad394d3)) * **rangeSlider:** use stats min/max when only user min or max is provided (#1124) ([4348463](4348463)), closes [#1004](#1004) * **searchBox:** force cursor position to be at the end of the query (#1123) ([8a27769](8a27769)), closes [#946](#946) * **searchBox:** IE8, IE9 needs to listen for setQuery ([97c166a](97c166a)) * **searchBox:** update helper query on every keystroke (#1127) ([997c0c2](997c0c2)), closes [#1015](#1015) * **urlSync:** urls should be safe by default (#1104) ([db833c6](db833c6)), closes [#982](#982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity of the searchBox starts to be crazy, mostly because we allowed too much different ways to instantiate it.
I will take that into account while doing V2 and React