Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class are doubled in the pagination markup #500

Closed
Shipow opened this issue Nov 8, 2015 · 0 comments
Closed

Class are doubled in the pagination markup #500

Shipow opened this issue Nov 8, 2015 · 0 comments
Assignees
Milestone

Comments

@Shipow
Copy link
Contributor

Shipow commented Nov 8, 2015

https://www.dropbox.com/s/5hudqcjw8eyuyve/Screenshot%202015-11-06%2015.17.18.png?dl=0

@Shipow Shipow changed the title Class are doubled int the pagination markup Class are doubled int the pagination marku Nov 8, 2015
@Shipow Shipow changed the title Class are doubled int the pagination marku Class are doubled in the pagination markup Nov 8, 2015
@vvo vvo added the Type: Bug label Nov 9, 2015
@vvo vvo added this to the 1.0.0 milestone Nov 9, 2015
@pixelastic pixelastic self-assigned this Nov 9, 2015
pixelastic added a commit that referenced this issue Nov 9, 2015
Fixes #500

BREAKING CHANGE: Removes all `__disabled`, `__first`, `__last`,
`__next`, `__previous`, `__active` and `__page` classes added on the links in the
pagination. It only ads them to the parent `li`. Links instead now
have a `.ais-pagination--link` class

Previously, the same CSS classes where added to both the `item` (`li`) and the
link inside it. I've split them in `--item` and `--link`.

I've also made the various active/first/disabled/etc modifiers as
actual `__modifier` classes.

I've updated the tests, the CSS skeleton, the examples and the docs
accordingly.
pixelastic added a commit that referenced this issue Nov 9, 2015
Fixes #500

BREAKING CHANGE: Removes all `__disabled`, `__first`, `__last`,
`__next`, `__previous`, `__active` and `__page` classes added on the links in the
pagination. It only ads them to the parent `li`. Links instead now
have a `.ais-pagination--link` class

Previously, the same CSS classes where added to both the `item` (`li`) and the
link inside it. I've split them in `--item` and `--link`.

I've also made the various active/first/disabled/etc modifiers as
actual `__modifier` classes.

I've updated the tests, the CSS skeleton, the examples and the docs
accordingly.
vvo pushed a commit that referenced this issue Nov 10, 2015
<a name="0.12.0"></a>
# [0.12.0](v0.11.1...v0.12.0) (2015-11-10)

### Bug Fixes

* **pagination:** Fix double BEM classes on elements ([2ede317](2ede317)), closes [#500](#500)
* **price-ranges:** fix usage + add test ([89601d7](89601d7))
* **range-slider:** check usage + display (fixes #395) ([301643a](301643a)), closes [#395](#395)
* **rangeSlider:** error when no result ([70e8554](70e8554))
* **theme:** Revert default spacing into pagination ([d755fd5](d755fd5))

### BREAKING CHANGES

* pagination: Removes all `__disabled`, `__first`, `__last`,
`__next`, `__previous`, `__active` and `__page` classes added on the links in the
pagination. It only ads them to the parent `li`. Links instead now
have a `.ais-pagination--link` class

Previously, the same CSS classes where added to both the `item` (`li`) and the
link inside it. I've split them in `--item` and `--link`.

I've also made the various active/first/disabled/etc modifiers as
actual `__modifier` classes.

I've updated the tests, the CSS skeleton, the examples and the docs
accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants