Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range slider pips and zero values #2343

Closed
fomalhaut79 opened this issue Sep 19, 2017 · 0 comments
Closed

Range slider pips and zero values #2343

fomalhaut79 opened this issue Sep 19, 2017 · 0 comments
Assignees
@iam4x
Labels
Type: Bug

Comments

@fomalhaut79
Copy link

fomalhaut79 commented Sep 19, 2017 •
edited by bobylito
Loading

Hello, I have 2 issues with Instantsearch Range Slider.

  1. Pips option doesn't work for me. Changing value to false doesn't remove pips.
  2. Zero values don't seem to work as intended. If I move slider there is no way to display zero value in a search anymore.

JsFiddle: https://jsfiddle.net/vladislav1979/nt384te0/12/
@iam4x iam4x mentioned this issue Sep 20, 2017
Merged
bobylito pushed a commit that referenced this issue Sep 20, 2017
@bobylito
fix(slider): Fix range slider pips and value 0 (#2350)
fa0dc09 
* fix(Slider): correctly disable pips
* fix(connectRangeSlider): dont apply numeric refinement
* test(range-slider): test pips & value 0
* fix(connectRangeSlider): correctly refine when no userSet min/max

fix #2343
bobylito pushed a commit that referenced this issue Sep 25, 2017
v2.1.5
8fb7c72 
<a name=2.1.5></a>
## [2.1.5](v2.1.4...v2.1.5) (2017-09-25)

### Bug Fixes

* **deps:** update dependency algolia-frontend-components to v^0.0.33 ([#2341](#2341)) ([16994d8](16994d8))
* **price-ranges:** update call to refine ([#2377](#2377)) ([34915d7](34915d7))
* **slider:** Fix range slider pips and value 0 ([#2350](#2350)) ([fa0dc09](fa0dc09)), closes [#2343](#2343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iam4x iam4x

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bobylito @iam4x @fomalhaut79