When URL sync is active, it requires two click to go back one step

[bobylito]

Do you want to request a feature or report a bug?
Bug.

Bug: What is the current behaviour?
When click on the browser back button, it requires two click to move back one step. Furthermore, when going back, it seems that we can't go forward (which indicates that we might have a new state that is recorded)

On https://demo.algolia.com/instant-search-demo/, follow these steps:

• select slowly three brands in the brand refinement list
• go back once --> goes back right away
• go back again --> nothing happens
• go back again --> goes a step back (can't go forward from there)

Bug: What is the expected behaviour?
One click --> one step back and have the ability to go forward.

Bug: What browsers are impacted? Which versions?
tested on chrome, latest.

Bug: What is the proposed solution?
🤷‍♀️

This bug is reproducible in both v1 and v2.

[bobylito]

This was introduced when I changed the update of the URL to only happen when there is a search. The problem comes from that we use to rely on change which would not be triggered because of the use of overrideStateWithoutTriggeringChangeEvent. But now we can't prevent the search event from happening.

We need to introduce a new state in the URL sync when the update comes from the URL (eg when popping a state from the history). This way we can prevent the timed out update of the URL from happening.

[bobylito]

The change is the way to go. The fact that URL updates when the searchbox is used with the options searchOnEnterKeyPress is not nice but that's better that any of the bugs introduced with using search instead of the change event.