-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 rangeSliders broken with undefined values #2169
Comments
Hi @timkelty thanks for the bug report :) We introduced the new implementation of the slider late in the beta that's why you don't have the issue using the beta-1. That being said, have you tried the latest beta-4? Will check on my side too :) |
Thank's for the repro case @timkelty I'm looking into it 👍 @bobylito Not working with beta4 (https://jsfiddle.net/vau0f2wx/1/) |
Yep, sorry meant to mention it occurs in beta 2 — 4 |
Good catch @timkelty should be fixed, I'm releasing a new beta. |
Fixed example https://jsfiddle.net/7agqwjjp/ |
Confirmed fixed with 2.0.0-beta.5. |
Do you want to request a feature or report a bug?
bug
Bug: What is the current behavior?
When there is a
rangeSlider
and the specifiedattributeName
is undefined/null in the results, it will incorrectly return "No results".Example: https://jsfiddle.net/timkelty/fLxzc27h/
It would seem it has something to do with how the
numericRefinements
are being set.I'm logging the search state and seeing something like this:
Since the filtered results are null/undefined, they get incorrectly filtered out, even though I'm not touching the
rangeSlider
.What is the version you are using? Always use the latest one before opening a bug issue.
This bug seems to have been introduced in 2.0.0.beta.2.
If I use 2.0.0.beta.1, it doesn't occur.
Here's the same jsFiddle with 2.0.0.beta.1, working: https://jsfiddle.net/timkelty/1g4m8m7q/
The text was updated successfully, but these errors were encountered: