Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 rangeSliders broken with undefined values #2169

Closed
timkelty opened this issue May 30, 2017 · 6 comments
Closed

v2 rangeSliders broken with undefined values #2169

timkelty opened this issue May 30, 2017 · 6 comments
Assignees

Comments

@timkelty
Copy link
Contributor

timkelty commented May 30, 2017

Do you want to request a feature or report a bug?
bug

Bug: What is the current behavior?
When there is a rangeSlider and the specified attributeName is undefined/null in the results, it will incorrectly return "No results".

Example: https://jsfiddle.net/timkelty/fLxzc27h/

  • Click the "Current Designs" refinementList facet.
  • it will show "no results", but should not (there are 90).
  • If you remove the rangeSlider widget, it will work properly

It would seem it has something to do with how the numericRefinements are being set.
I'm logging the search state and seeing something like this:

screen shot 2017-05-30 at 11 18 34 am

Since the filtered results are null/undefined, they get incorrectly filtered out, even though I'm not touching the rangeSlider.

What is the version you are using? Always use the latest one before opening a bug issue.

This bug seems to have been introduced in 2.0.0.beta.2.
If I use 2.0.0.beta.1, it doesn't occur.
Here's the same jsFiddle with 2.0.0.beta.1, working: https://jsfiddle.net/timkelty/1g4m8m7q/

@bobylito
Copy link
Contributor

Hi @timkelty thanks for the bug report :) We introduced the new implementation of the slider late in the beta that's why you don't have the issue using the beta-1.

That being said, have you tried the latest beta-4? Will check on my side too :)

@iam4x
Copy link
Contributor

iam4x commented May 31, 2017

Thank's for the repro case @timkelty I'm looking into it 👍

@bobylito Not working with beta4 (https://jsfiddle.net/vau0f2wx/1/)

@timkelty
Copy link
Contributor Author

That being said, have you tried the latest beta-4? Will check on my side too :)

Yep, sorry meant to mention it occurs in beta 2 — 4

@iam4x
Copy link
Contributor

iam4x commented Jun 1, 2017

Good catch @timkelty should be fixed, I'm releasing a new beta.

@iam4x
Copy link
Contributor

iam4x commented Jun 1, 2017

Fixed example https://jsfiddle.net/7agqwjjp/

@iam4x iam4x closed this as completed Jun 1, 2017
@timkelty
Copy link
Contributor Author

timkelty commented Jun 1, 2017

Confirmed fixed with 2.0.0-beta.5.
Thanks @iam4x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants