Skip to content

Commit

Permalink
perf(nouislider): upgrade nouislider, shaves some more ms
Browse files Browse the repository at this point in the history
  • Loading branch information
vvo committed Feb 11, 2016
1 parent 358b5cd commit fefbe65
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 13 deletions.
8 changes: 4 additions & 4 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"lodash": "^3.10.1",
"react": "^0.14.7",
"react-dom": "^0.14.7",
"react-nouislider": "^1.7.0",
"react-nouislider": "^1.7.1",
"to-factory": "^1.0.0"
},
"license": "MIT"
Expand Down
7 changes: 6 additions & 1 deletion src/components/Slider/Slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class Slider extends React.Component {
} else {
pips = this.props.pips;
}

return (
<Nouislider
{...this.props}
Expand All @@ -64,7 +65,11 @@ Slider.propTypes = {
start: React.PropTypes.arrayOf(React.PropTypes.number).isRequired,
tooltips: React.PropTypes.oneOfType([
React.PropTypes.bool,
React.PropTypes.object
React.PropTypes.arrayOf(
React.PropTypes.shape({
to: React.PropTypes.func
})
)
])
};

Expand Down
18 changes: 11 additions & 7 deletions src/widgets/range-slider/range-slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ function rangeSlider({
Slider = autoHideContainerHOC(Slider);
}

let cssClasses = {
root: cx(bem(null), userCssClasses.root),
header: cx(bem('header'), userCssClasses.header),
body: cx(bem('body'), userCssClasses.body),
footer: cx(bem('footer'), userCssClasses.footer)
};

return {
getConfiguration: () => ({
disjunctiveFacets: [attributeName]
Expand Down Expand Up @@ -109,13 +116,6 @@ function rangeSlider({
});
},
render({results, helper}) {
let cssClasses = {
root: cx(bem(null), userCssClasses.root),
header: cx(bem('header'), userCssClasses.header),
body: cx(bem('body'), userCssClasses.body),
footer: cx(bem('footer'), userCssClasses.footer)
};

let facet = find(results.disjunctiveFacets, {name: attributeName});
let stats = facet !== undefined ? facet.stats : undefined;
let currentRefinement = this._getCurrentRefinement(helper);
Expand All @@ -127,6 +127,10 @@ function rangeSlider({
};
}

if (tooltips.format !== undefined) {
tooltips = [{to: tooltips.format}, {to: tooltips.format}];
}

ReactDOM.render(
<Slider
cssClasses={cssClasses}
Expand Down

0 comments on commit fefbe65

Please sign in to comment.