-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(bem): Make scss mixins actually follow BEM
The mixins and internal variable where misnamed. We use the BEM naming with the following pattern: `.ais-block--element__modifier`. Mixins where usin `component` instead of `block` and where swapping `element` and `modifier`. I've reverted to something more readable.
- Loading branch information
1 parent
fbeff9b
commit fcfb408
Showing
36 changed files
with
313 additions
and
311 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,42 @@ | ||
@import "../base"; | ||
@import "variables"; | ||
|
||
@include component(hierarchical-menu) { | ||
@include modifier(header) { | ||
@include block(hierarchical-menu) { | ||
@include element(header) { | ||
/* widget header */ | ||
} | ||
@include modifier(body) { | ||
@include element(body) { | ||
/* widget body */ | ||
} | ||
@include modifier(list) { | ||
@include element(list) { | ||
/* item list */ | ||
@include element(lvl0) { | ||
@include modifier(lvl0) { | ||
/* item list level 0 */ | ||
} | ||
@include element(lvl1) { | ||
@include modifier(lvl1) { | ||
/* item list level 1 */ | ||
margin-left: 10px; | ||
} | ||
@include element(lvl2) { | ||
@include modifier(lvl2) { | ||
/* item list level 0 */ | ||
margin-left: 10px; | ||
} | ||
} | ||
|
||
@include modifier(item) { | ||
@include element(item) { | ||
/* list item */ | ||
@include element(active) { | ||
@include modifier(active) { | ||
/* active list item */ | ||
} | ||
} | ||
|
||
@include modifier(link) { | ||
@include element(link) { | ||
/* item link */ | ||
} | ||
@include modifier(count) { | ||
@include element(count) { | ||
/* item count */ | ||
} | ||
@include modifier(footer) { | ||
@include element(footer) { | ||
/* widget footer */ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
@import "../base"; | ||
@import "variables"; | ||
|
||
@include component(hits) { | ||
@include element(empty) { | ||
@include block(hits) { | ||
@include modifier(empty) { | ||
/* empty container */ | ||
} | ||
@include modifier(item) { | ||
@include element(item) { | ||
/* hit item */ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
@import "../base"; | ||
@import "variables"; | ||
|
||
@include component(index-selector) { | ||
@include modifier(item) { | ||
@include block(index-selector) { | ||
@include element(item) { | ||
/* selector item */ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,29 @@ | ||
@import "../base"; | ||
@import "variables"; | ||
|
||
@include component(menu) { | ||
@include modifier(header) { | ||
@include block(menu) { | ||
@include element(header) { | ||
/* widget header */ | ||
} | ||
@include modifier(body) { | ||
@include element(body) { | ||
/* widget body */ | ||
} | ||
@include modifier(list) { | ||
@include element(list) { | ||
/* item list */ | ||
} | ||
@include modifier(item) { | ||
@include element(item) { | ||
/* list item */ | ||
@include element(active) { | ||
@include modifier(active) { | ||
/* active list item */ | ||
} | ||
} | ||
@include modifier(link) { | ||
@include element(link) { | ||
/* item link */ | ||
} | ||
@include modifier(count) { | ||
@include element(count) { | ||
/* item count */ | ||
} | ||
@include modifier(footer) { | ||
@include element(footer) { | ||
/* widget footer */ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,30 @@ | ||
@import "../base"; | ||
@import "variables"; | ||
|
||
@include component(pagination) { | ||
@include modifier(item) { | ||
@include block(pagination) { | ||
@include element(item) { | ||
/* pagination item */ | ||
@include element(disabled) { | ||
@include modifier(disabled) { | ||
/* disabled pagination item */ | ||
visibility: hidden; | ||
} | ||
} | ||
@include modifier(item-first) { | ||
@include element(item-first) { | ||
/* first pagination item */ | ||
} | ||
@include modifier(item-previous) { | ||
@include element(item-previous) { | ||
/* previous pagination item */ | ||
} | ||
@include modifier(item-page) { | ||
@include element(item-page) { | ||
/* page */ | ||
@include element(active) { | ||
@include modifier(active) { | ||
/* active page */ | ||
} | ||
} | ||
@include modifier(item-next) { | ||
@include element(item-next) { | ||
/* next pagination item */ | ||
} | ||
@include modifier(item-last) { | ||
@include element(item-last) { | ||
/* last pagination item */ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.