-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): recursively merge arrays in searchParameters
fixes #80
- Loading branch information
vvo
committed
Sep 10, 2015
1 parent
8b8965d
commit dbadcdb
Showing
5 changed files
with
91 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -e # exit when error | ||
|
||
printf "\nTest\n" | ||
|
||
babel-tape-runner test/**/*.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
test/InstantSearch/recursively-merge-arrays-searchParameters.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
var test = require('tape'); | ||
|
||
test('InstantSearch: recursively merge arrays in searchParameters', function(t) { | ||
var EventEmitter = require('events').EventEmitter; | ||
|
||
var proxyquire = require('proxyquire'); | ||
var sinon = require('sinon'); | ||
|
||
// simple mocks | ||
var helper = new EventEmitter(); | ||
helper.search = noop; | ||
|
||
// hijack `algoliasearch` and `algoliasearchHelper` modules | ||
var algoliasearch = noop; | ||
var algoliasearchHelper = sinon.stub().returns(helper); | ||
|
||
var searchParameters = { | ||
some: ['value', 'another value'], | ||
cool: 3, | ||
another: {nested: ['array', 'of', 'values']} | ||
}; | ||
|
||
var firstWidget = { | ||
getConfiguration: sinon.stub().returns({ | ||
first: ['values'], | ||
some: ['first'], | ||
another: {yes: true} | ||
}) | ||
}; | ||
|
||
var secondWidget = { | ||
getConfiguration: sinon.stub().returns({ | ||
first: ['new value'], | ||
cool: 4, | ||
another: {nested: ['thing'], yes: false}, | ||
some: ['second'] | ||
}) | ||
}; | ||
|
||
var InstantSearch = proxyquire('../../lib/InstantSearch', { | ||
algoliasearch: algoliasearch, | ||
'algoliasearch-helper': algoliasearchHelper | ||
}); | ||
|
||
var search = new InstantSearch('appId', 'apiKey', 'recursively', searchParameters); | ||
|
||
search.addWidget(firstWidget); | ||
search.addWidget(secondWidget); | ||
search.start(); | ||
|
||
var expected = { | ||
first: ['values', 'new value'], | ||
some: ['value', 'another value', 'first', 'second'], | ||
cool: 4, | ||
another: {nested: ['array', 'of', 'values', 'thing'], yes: false} | ||
}; | ||
|
||
t.deepEqual( | ||
algoliasearchHelper.args[0][2], | ||
expected | ||
); | ||
|
||
t.end(); | ||
}); | ||
|
||
function noop() {} |